Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1431843002: Fix signed-compare error with gcc 4.9.2. (Closed)

Created:
5 years, 1 month ago by paul.l...
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix signed-compare error with gcc 4.9.2. From 41f3e782d968. BUG= Committed: https://crrev.com/0bc51ef6208b4c98e51ba726c9ea974c206e66d0 Cr-Commit-Position: refs/heads/master@{#31807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431843002/1
5 years, 1 month ago (2015-11-04 19:24:09 UTC) #2
paul.l...
PTAL.
5 years, 1 month ago (2015-11-04 19:24:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 19:42:35 UTC) #6
rmcilroy
lgtm
5 years, 1 month ago (2015-11-04 21:42:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431843002/1
5 years, 1 month ago (2015-11-04 22:04:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 22:06:27 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 22:07:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bc51ef6208b4c98e51ba726c9ea974c206e66d0
Cr-Commit-Position: refs/heads/master@{#31807}

Powered by Google App Engine
This is Rietveld 408576698