content/browser/renderer_host/render_view_host_delegate.h - Issue 143183009: When cross-site navigations are cancelled, delete the request being transferred

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 143183009: When cross-site navigations are cancelled, delete the request being transferred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: reupload, undo unneeded change Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/cross_site_request_transfer.h ('K') | « content/browser/renderer_host/cross_site_request_transfer.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | content/browser/site_per_process_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_delegate.h

===================================================================

--- content/browser/renderer_host/render_view_host_delegate.h (revision 250813)

+++ content/browser/renderer_host/render_view_host_delegate.h (working copy)

@@ -46,6 +46,7 @@

namespace content {

class BrowserContext;

+class CrossSiteRequestTransfer;

class FrameTree;

class PageState;

class RenderViewHost;

@@ -93,10 +94,12 @@

// The |pending_render_view_host| is ready to commit a page. The delegate

// should ensure that the old RenderViewHost runs its unload handler first

// and determine whether a RenderViewHost transfer is needed.

+ // |request_transfer| is NULL if a request is not being transferred between

Charlie Reis 2014/02/13 22:12:19 nit: request_transfer doesn't match parameter name

mmenke 2014/02/14 16:30:02 Done.

+ // renderers.

virtual void OnCrossSiteResponse(

RenderViewHost* pending_render_view_host,

const GlobalRequestID& global_request_id,

- bool is_transfer,

+ scoped_ptr<CrossSiteRequestTransfer> cross_site_request_transfer,

const std::vector<GURL>& transfer_url_chain,

const Referrer& referrer,

PageTransition page_transition,