When cross-site navigations are cancelled, delete the request being transferred

content/browser/loader/cross_site_resource_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_LOADER_CROSS_SITE_RESOURCE_HANDLER_H_
 #define CONTENT_BROWSER_LOADER_CROSS_SITE_RESOURCE_HANDLER_H_
 
 #include "base/memory/ref_counted.h"
 #include "content/browser/loader/layered_resource_handler.h"
+#include "content/common/content_export.h"
 #include "net/url_request/url_request_status.h"
 
 namespace net {
 class URLRequest;
 }
 
 namespace content {
 
 // Ensures that cross-site responses are delayed until the onunload handler of
 // the previous page is allowed to run.  This handler wraps an
@@ skipping 19 matching lines @@
                                bool* defer) OVERRIDE;
   virtual void OnResponseCompleted(int request_id,
                                    const net::URLRequestStatus& status,
                                    const std::string& security_info,
                                    bool* defer) OVERRIDE;
 
   // We can now send the response to the new renderer, which will cause
   // WebContentsImpl to swap in the new renderer and destroy the old one.
   void ResumeResponse();
 
+  // In the case that the request is being transferred and the cross-site
+  // navigation is cancelled, cancels and deletes the request.  This is needed
+  // to avoid leaking the request.
+  void AbortTransfer();

[Charlie Reis, 2014/02/15 01:25:45]

Let's remove this.

[mmenke, 2014/02/15 02:15:13]

Done, thanks for catching this!

+
+  // When set to true, requests are leaked when they can't be passed to a
+  // RenderViewHost, for unit tests.
+  CONTENT_EXPORT static void SetLeakRequestsForTesting(
+      bool leak_requests_for_testing);
+
  private:
   // Prepare to render the cross-site response in a new RenderViewHost, by
   // telling the old RenderViewHost to run its onunload handler.
   void StartCrossSiteTransition(int request_id,
                                 ResourceResponse* response,
                                 bool should_transfer);
 
   void ResumeIfDeferred();
 
   bool has_started_response_;
   bool in_cross_site_transition_;
   bool completed_during_transition_;
   bool did_defer_;
   net::URLRequestStatus completed_status_;
   std::string completed_security_info_;
   scoped_refptr<ResourceResponse> response_;
 
   DISALLOW_COPY_AND_ASSIGN(CrossSiteResourceHandler);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_LOADER_CROSS_SITE_RESOURCE_HANDLER_H_