google_apis/gaia/gaia_auth_util.cc - Issue 143183007: Update policy signature verification to include policy domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_auth_util.cc

Issue 143183007: Update policy signature verification to include policy domain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Trying again after mysterious chunk-mismatch error on last upload. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/gaia_auth_util.cc

diff --git a/google_apis/gaia/gaia_auth_util.cc b/google_apis/gaia/gaia_auth_util.cc

index 3aabd0770972b769328d7c324c13bdbbfdaf0a6c..edc0bae1d70bab53b3dbaab34404bc022d2a06b3 100644

--- a/google_apis/gaia/gaia_auth_util.cc

+++ b/google_apis/gaia/gaia_auth_util.cc

@@ -23,7 +23,8 @@ std::string CanonicalizeEmail(const std::string& email_address) {

char at = '@';

base::SplitString(email_address, at, &parts);

if (parts.size() != 2U)

- NOTREACHED() << "expecting exactly one @, but got " << parts.size();

+ NOTREACHED() << "expecting exactly one @, but got " << parts.size()-1 <<

+ " : " << email_address;

else if (parts[1] == kGmailDomain) // only strip '.' for gmail accounts.

base::RemoveChars(parts[0], ".", &parts[0]);

std::string new_email = StringToLowerASCII(JoinString(parts, at));