chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc - Issue 143183007: Update policy signature verification to include policy domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

Issue 143183007: Update policy signature verification to include policy domain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Trying again after mysterious chunk-mismatch error on last upload. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_local_account_policy_store.cc » ('j') | chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

index a4a2e99f171f6a1494f76cfacc23e8f00b6a93d9..70434098c7126d4cd19a96481ec20ce40a8064a6 100644

--- a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

+++ b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

@@ -48,7 +48,7 @@ void DeviceCloudPolicyStoreChromeOS::Store(

scoped_ptr<DeviceCloudPolicyValidator> validator(CreateValidator(policy));

validator->ValidateSignature(owner_key->public_key_as_string(),

GetPolicyVerificationKey(),

- std::string(),

+ install_attributes_->GetDomain(),

true);

validator->ValidateAgainstCurrentPolicy(

device_settings_service_->policy_data(),

@@ -77,7 +77,8 @@ void DeviceCloudPolicyStoreChromeOS::InstallInitialPolicy(

}

scoped_ptr<DeviceCloudPolicyValidator> validator(CreateValidator(policy));

- validator->ValidateInitialKey(GetPolicyVerificationKey());

+ validator->ValidateInitialKey(GetPolicyVerificationKey(),

+ install_attributes_->GetDomain());

validator.release()->StartValidation(

base::Bind(&DeviceCloudPolicyStoreChromeOS::OnPolicyToStoreValidated,

weak_factory_.GetWeakPtr()));