Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1431813002: Adapt long branches to use bc & balc on r6. (Closed)

Created:
5 years, 1 month ago by balazs.kilvady
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Adapt long branches to use bc & balc on r6. BUG= Committed: https://crrev.com/bddf8c9e081f70fc1dad8343040bb4c97dda8890 Cr-Commit-Position: refs/heads/master@{#31878}

Patch Set 1 #

Patch Set 2 : Rebased, Fix condition ordering for readability. #

Patch Set 3 : Fix variable name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -55 lines) Patch
M src/mips/assembler-mips.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 2 6 chunks +37 lines, -10 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 18 chunks +59 lines, -43 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
balazs.kilvady
5 years, 1 month ago (2015-11-04 17:47:00 UTC) #2
balazs.kilvady
Small fixes.
5 years, 1 month ago (2015-11-05 14:43:51 UTC) #3
paul.l...
LGTM. Djordje, can you take a look at this too?
5 years, 1 month ago (2015-11-06 06:45:57 UTC) #5
paul.l...
nit: please edit the title to start with "MIPS: "
5 years, 1 month ago (2015-11-06 07:06:57 UTC) #6
Djordje.Pesic
On 2015/11/06 07:06:57, paul.l... wrote: > nit: please edit the title to start with "MIPS: ...
5 years, 1 month ago (2015-11-09 07:45:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431813002/40001
5 years, 1 month ago (2015-11-09 11:07:11 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-09 11:25:09 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 11:25:32 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bddf8c9e081f70fc1dad8343040bb4c97dda8890
Cr-Commit-Position: refs/heads/master@{#31878}

Powered by Google App Engine
This is Rietveld 408576698