Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 1431793002: Remove [TreatNullAs=NullString] from attributes on RTCIceCandidate (Closed)

Created:
5 years, 1 month ago by tanay.c
Modified:
5 years, 1 month ago
CC:
philipj_slow, Mike West
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [TreatNullAs=NullString] from attributes on RTCIceCandidate Current Behaviour: Chrome : RTCIceCandidate.candidate = null => "" RTCIceCandidate.sdpMid = null => "" Firefox : RTCIceCandidate.candidate = null => "null" RTCIceCandidate.sdpMid = null => "null" After the change: Chrome: RTCIceCandidate.candidate = null => "null" RTCIceCandidate.sdpMid = null => "null" This aligns with the behavior on Firefox nightly BUG=497307 Committed: https://crrev.com/11459efcc7693831a14ed164a20c8aa79fd770ba Cr-Commit-Position: refs/heads/master@{#361087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/RTCIceCandidate.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCIceCandidate-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCIceCandidate.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
tanay.c
mkwst@chromium.org: Please review changes in
5 years, 1 month ago (2015-11-04 11:57:33 UTC) #4
tanay.c
PTAL.
5 years, 1 month ago (2015-11-04 11:57:57 UTC) #5
philipj_slow
Assigning to module owners instead. FWIW, change and tests look good to me.
5 years, 1 month ago (2015-11-04 12:29:35 UTC) #7
Peter Beverloo
On 2015/11/04 12:29:35, philipj wrote: > Assigning to module owners instead. FWIW, change and tests ...
5 years, 1 month ago (2015-11-06 13:02:44 UTC) #8
tommi (sloooow) - chröme
hta - wdyt?
5 years, 1 month ago (2015-11-09 21:59:53 UTC) #10
hta - Chromium
lgtm I see no reason not to do it. Compatibility is improved.
5 years, 1 month ago (2015-11-20 13:00:18 UTC) #11
Peter Beverloo
rs lgtm Thank you, hta!
5 years, 1 month ago (2015-11-20 13:14:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431793002/1
5 years, 1 month ago (2015-11-23 10:03:46 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 11:16:56 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 11:17:48 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11459efcc7693831a14ed164a20c8aa79fd770ba
Cr-Commit-Position: refs/heads/master@{#361087}

Powered by Google App Engine
This is Rietveld 408576698