Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1431783002: Adding a layout test for drawing a live video to a canvas (Closed)

Created:
5 years, 1 month ago by Justin Novosad
Modified:
5 years, 1 month ago
Reviewers:
Stephen White
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a layout test for drawing a live video to a canvas BUG=548788 R=senorblanco@chromium.org Committed: https://crrev.com/185e060d71f6320e18777adbec74b22e020a2a24 Cr-Commit-Position: refs/heads/master@{#357934}

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo fix #

Messages

Total messages: 11 (4 generated)
Justin Novosad
PTAL
5 years, 1 month ago (2015-11-04 05:13:11 UTC) #1
Justin Novosad
5 years, 1 month ago (2015-11-04 22:37:45 UTC) #4
Stephen White
LGTM w/nit fixed https://codereview.chromium.org/1431783002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html (right): https://codereview.chromium.org/1431783002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html#newcode3 third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html:3: <style trpe="text/css"> type?
5 years, 1 month ago (2015-11-04 22:40:24 UTC) #5
Justin Novosad
On 2015/11/04 22:40:24, Stephen White wrote: > LGTM w/nit fixed > > https://codereview.chromium.org/1431783002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html > File ...
5 years, 1 month ago (2015-11-04 22:42:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431783002/20001
5 years, 1 month ago (2015-11-04 22:49:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 23:45:07 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 23:46:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/185e060d71f6320e18777adbec74b22e020a2a24
Cr-Commit-Position: refs/heads/master@{#357934}

Powered by Google App Engine
This is Rietveld 408576698