chrome/browser/about_flags.cc - Issue 1431723002: Add brotli content-encoding filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1431723002: Add brotli content-encoding filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use features instead of command line flags Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index f954b05769264d0bff3c261e707f13b55abd8403..f5fcdf8d4774408aeb7ed6f803f8e3fdfc871f3c 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -55,6 +55,7 @@

#include "grit/components_strings.h"

#include "media/base/media_switches.h"

#include "media/midi/midi_switches.h"

+#include "net/http/http_features.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/ui_base_switches.h"

#include "ui/display/display_switches.h"

@@ -2020,6 +2021,13 @@ const FeatureEntry kFeatureEntries[] = {

ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAppContainer,

switches::kDisableAppContainer)},

#endif // defined(OS_WIN)

+#if !defined(DISABLE_BROTLI_SUPPORT)

+ {"enable-brotli",

+ IDS_FLAGS_ENABLE_BROTLI_NAME,

+ IDS_FLAGS_ENABLE_BROTLI_DESCRIPTION,

+ kOsAll,

+ FEATURE_VALUE_TYPE(net::features::kBrotliEncodingFeature)},

+#endif

xunjieli 2015/12/14 16:02:27 nit: suggest adding a comment at the end. #endif

eustas 2015/12/14 17:39:45 Done.

#if defined(OS_ANDROID)

{"disable-auto-hiding-toolbar-threshold",

IDS_FLAGS_DISABLE_AUTO_HIDING_TOOLBAR_NAME,