net/http/http_features.cc - Issue 1431723002: Add brotli content-encoding filter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/http/http_features.cc

Issue 1431723002: Add brotli content-encoding filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use features instead of command line flags Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "net/http/http_features.h"

	6

	7 namespace net {

	8

	9 namespace features {

	10

	11 // Enables brotli "Accept-Encooding" advertising and "Content-Encoding" support.
	xunjieli 2015/12/14 16:02:27 Could you also link ietf draft here? http://www.ie Could you also link ietf draft here? http://www.ietf.org/id/draft-alakuijala-brotli xunjieli 2015/12/14 16:02:27 nit: typo in Encoding nit: typo in Encoding eustas 2015/12/14 17:39:45 Done. Show quoted text On 2015/12/14 16:02:27, xunjieli wrote: > Could you also link ietf draft here? > http://www.ietf.org/id/draft-alakuijala-brotli Done. eustas 2015/12/14 17:39:45 Done. Show quoted text On 2015/12/14 16:02:27, xunjieli wrote: > nit: typo in Encoding Done.
	12 const base::Feature kBrotliEncodingFeature = {

	13 "brotli-encoding", base::FEATURE_DISABLED_BY_DEFAULT};

	14

	15 bool IsBrotliEncodingEnabled() {

	16 #if !defined(DISABLE_BROTLI_SUPPORT)

	17 return base::FeatureList::IsEnabled(kBrotliEncodingFeature);

	18 #else

	19 return false;

	20 #endif

	21 }

	22

	23 } // namespace features

	24

	25 } // namespace net

OLD	NEW