Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1431713002: tools/git-sync-deps: speed up common case by skipping fetch (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

tools/git-sync-deps: speed up common case by skipping fetch Committed: https://skia.googlesource.com/skia/+/6aff54c32283614dc5d5acde82aef6919bc166da

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2015-11-03 (Tuesday) 12:34:44 EST #

Patch Set 3 : 2015-11-03 (Tuesday) 12:36:14 EST #

Patch Set 4 : 2015-11-03 (Tuesday) 12:37:42 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/git-sync-deps View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hal.canary
PTAL
5 years, 1 month ago (2015-11-03 17:21:25 UTC) #2
mtklein
https://codereview.chromium.org/1431713002/diff/1/tools/git-sync-deps File tools/git-sync-deps (right): https://codereview.chromium.org/1431713002/diff/1/tools/git-sync-deps#newcode138 tools/git-sync-deps:138: subprocess.check_call( if 0 == subprocess.call(...): if verbose: ... return ...
5 years, 1 month ago (2015-11-03 17:29:29 UTC) #3
hal.canary
https://codereview.chromium.org/1431713002/diff/1/tools/git-sync-deps File tools/git-sync-deps (right): https://codereview.chromium.org/1431713002/diff/1/tools/git-sync-deps#newcode138 tools/git-sync-deps:138: subprocess.check_call( On 2015/11/03 at 17:29:29, mtklein wrote: > if ...
5 years, 1 month ago (2015-11-03 17:35:15 UTC) #4
mtklein
lgtm
5 years, 1 month ago (2015-11-03 17:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431713002/60001
5 years, 1 month ago (2015-11-03 17:38:27 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 17:50:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6aff54c32283614dc5d5acde82aef6919bc166da

Powered by Google App Engine
This is Rietveld 408576698