Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: tests/callingconv_case_by_case/for_each_type.h

Issue 14317008: PNaCl: Enable ExpandByVal pass for expanding out passing structs by value (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pnacl/driver/pnacl-ld.py ('K') | « pnacl/driver/pnacl-ld.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/callingconv_case_by_case/for_each_type.h
diff --git a/tests/callingconv_case_by_case/for_each_type.h b/tests/callingconv_case_by_case/for_each_type.h
index 9ac24dd97ac9d1a51dbebcaa73d5bf00ce75a585..7321d120bc1bf5bd5294c4735a02a9d8edccd7eb 100644
--- a/tests/callingconv_case_by_case/for_each_type.h
+++ b/tests/callingconv_case_by_case/for_each_type.h
@@ -39,7 +39,13 @@ DO_FOR_TYPE(FLOAT_FLOAT)
DO_FOR_TYPE(STRUCT_STRUCT)
DO_FOR_TYPE(DOUBLE_DOUBLE)
DO_FOR_TYPE(CHAR_BOOL_I32_BOOL)
-DO_FOR_TYPE(I32_ALIGN16)
+/*
+ * pnacl-clang does not align struct arguments correctly when the
+ * struct type is declared with __attribute__((aligned)). This causes
+ * this test to fault on an unaligned "movaps" instruction on x86.
+ * See https://code.google.com/p/nativeclient/issues/detail?id=3403
+ */
+/* DO_FOR_TYPE(I32_ALIGN16) */
DO_FOR_TYPE(I32_CHAR12)
DO_FOR_TYPE(ARRAY_I32_4)
DO_FOR_TYPE(ARRAY_FLOAT_4)
@@ -49,7 +55,11 @@ DO_FOR_TYPE(CHAR_I64_I32)
DO_FOR_TYPE(BITFIELD_STRADDLE)
DO_FOR_TYPE(NONBITFIELD_STRADDLE)
-DO_FOR_TYPE(I32_CHAR_ALIGN32)
+/*
+ * pnacl-clang does not align __attribute__((aligned)) structs
+ * correctly. See above.
+ */
+/* DO_FOR_TYPE(I32_CHAR_ALIGN32) */
DO_FOR_TYPE(U_I64_DOUBLE)
DO_FOR_TYPE(U_DOUBLE_I64)
« pnacl/driver/pnacl-ld.py ('K') | « pnacl/driver/pnacl-ld.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698