Source/core/platform/image-decoders/gif/GIFImageDecoder.h - Issue 14317005: Checking if frame is complete and access duration doesn't need a decode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/image-decoders/gif/GIFImageDecoder.h

Issue 14317005: Checking if frame is complete and access duration doesn't need a decode (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fixed nits Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/platform/image-decoders/gif/GIFImageDecoder.h

diff --git a/Source/core/platform/image-decoders/gif/GIFImageDecoder.h b/Source/core/platform/image-decoders/gif/GIFImageDecoder.h

index a4728d33a7368d77431bcc7e24d721877af2999e..b05f2a177f47ff3b91de6830e77d54bb26fb957d 100644

--- a/Source/core/platform/image-decoders/gif/GIFImageDecoder.h

+++ b/Source/core/platform/image-decoders/gif/GIFImageDecoder.h

@@ -49,6 +49,8 @@ namespace WebCore {

virtual size_t frameCount();

virtual int repetitionCount() const;

virtual ImageFrame* frameBufferAtIndex(size_t index);

+ virtual bool frameIsCompleteAtIndex(size_t) const;

+ virtual float frameDurationAtIndex(size_t) const;

Alpha Left Google 2013/04/26 20:43:36 Done. Now it has a default implementation.

// CAUTION: setFailed() deletes |m_reader|. Be careful to avoid

// accessing deleted memory, especially when calling this from inside

// GIFImageReader!