Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1431693003: dart2js: add OutputUnit info for constants (Closed)

Created:
5 years, 1 month ago by Harry Terkelsen
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 1 8 chunks +33 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 1 month ago (2015-11-03 01:58:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1431693003/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/1431693003/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode342 pkg/compiler/lib/src/dump_info.dart:342: return _outputToInfo.putIfAbsent(outputUnit, () { nit: let's factor out ...
5 years, 1 month ago (2015-11-03 02:30:18 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1431693003/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/1431693003/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode342 pkg/compiler/lib/src/dump_info.dart:342: return _outputToInfo.putIfAbsent(outputUnit, () { On 2015/11/03 02:30:18, Siggi Cherem ...
5 years, 1 month ago (2015-11-03 02:43:34 UTC) #4
Harry Terkelsen
5 years, 1 month ago (2015-11-03 02:44:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1b708855ca04c71830ab830f31b23a1d4bd8fb9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698