Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: net/quic/quic_protocol.cc

Issue 1431693002: Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now ignores all but the… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106724344
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_received_packet_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.cc
diff --git a/net/quic/quic_protocol.cc b/net/quic/quic_protocol.cc
index 1e11c6ed30ea3f99e06b13cca4f18da0899c0960..a26c335e8fba2336e148bff39b83f70b3a9545b7 100644
--- a/net/quic/quic_protocol.cc
+++ b/net/quic/quic_protocol.cc
@@ -241,7 +241,8 @@ QuicAckFrame::QuicAckFrame()
: entropy_hash(0),
is_truncated(false),
largest_observed(0),
- delta_time_largest_observed(QuicTime::Delta::Infinite()) {}
+ delta_time_largest_observed(QuicTime::Delta::Infinite()),
+ latest_revived_packet(0) {}
QuicAckFrame::~QuicAckFrame() {}
@@ -474,13 +475,9 @@ ostream& operator<<(ostream& os, const QuicAckFrame& ack_frame) {
<< " delta_time_largest_observed: "
<< ack_frame.delta_time_largest_observed.ToMicroseconds()
<< " missing_packets: [ " << ack_frame.missing_packets
- << " ] is_truncated: " << ack_frame.is_truncated;
- os << " revived_packets: [ ";
- for (PacketNumberSet::const_iterator it = ack_frame.revived_packets.begin();
- it != ack_frame.revived_packets.end(); ++it) {
- os << *it << " ";
- }
- os << " ] received_packets: [ ";
+ << " ] is_truncated: " << ack_frame.is_truncated
+ << " revived_packet: " << ack_frame.latest_revived_packet
+ << " received_packets: [ ";
for (const std::pair<QuicPacketNumber, QuicTime>& p :
ack_frame.received_packet_times) {
os << p.first << " at " << p.second.ToDebuggingValue() << " ";
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_received_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698