Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1431683006: Take mutex when calling into FreeType. (Closed)

Created:
5 years, 1 month ago by bungeman-skia
Modified:
5 years, 1 month ago
Reviewers:
herb_g, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Take mutex when calling into FreeType. SkScalerContext_FreeType::generateCharToGlyph and generateGlyphToChar do not take a mutex when calling into FreeType, but they need to. The setupSize method also requires the mutex to be locked, which is not a problem since it currently always is, but add a debug assert to ensure that it continues to be. BUG=chromium:542640 Committed: https://skia.googlesource.com/skia/+/3f846ae913f0e01eedf889fff062e9a1dc9f4f8b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431683006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431683006/1
5 years, 1 month ago (2015-11-03 18:50:09 UTC) #2
bungeman-skia
5 years, 1 month ago (2015-11-03 18:54:31 UTC) #4
mtklein
lgtm
5 years, 1 month ago (2015-11-03 19:03:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 19:03:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431683006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431683006/1
5 years, 1 month ago (2015-11-03 19:06:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3f846ae913f0e01eedf889fff062e9a1dc9f4f8b
5 years, 1 month ago (2015-11-03 19:07:23 UTC) #10
herb_g
5 years, 1 month ago (2015-11-03 19:09:28 UTC) #11
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1431683006/diff/1/src/ports/SkFontHost_FreeTy...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/1431683006/diff/1/src/ports/SkFontHost_FreeTy...
src/ports/SkFontHost_FreeType.cpp:951: FT_Error
SkScalerContext_FreeType::setupSize() {
Maybe change the name to indicate that this routine assumes a held lock.
setupSizeLocked?

Powered by Google App Engine
This is Rietveld 408576698