Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 1431683004: Oilpan: add missing pointer initialization after r357529. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 result->setNumber("height", size.height()); 407 result->setNumber("height", size.height());
408 return result.release(); 408 return result.release();
409 } 409 }
410 410
411 void InspectorOverlay::drawNodeHighlight() 411 void InspectorOverlay::drawNodeHighlight()
412 { 412 {
413 if (!m_highlightNode) 413 if (!m_highlightNode)
414 return; 414 return;
415 415
416 String selectors = m_nodeHighlightConfig.selectorList; 416 String selectors = m_nodeHighlightConfig.selectorList;
417 RefPtrWillBeRawPtr<StaticElementList> elements; 417 RefPtrWillBeRawPtr<StaticElementList> elements = nullptr;
418 TrackExceptionState exceptionState; 418 TrackExceptionState exceptionState;
419 if (selectors.length()) 419 if (selectors.length())
420 elements = m_highlightNode->ownerDocument()->querySelectorAll(AtomicStri ng(selectors), exceptionState); 420 elements = m_highlightNode->ownerDocument()->querySelectorAll(AtomicStri ng(selectors), exceptionState);
421 if (elements && !exceptionState.hadException()) { 421 if (elements && !exceptionState.hadException()) {
422 for (unsigned i = 0; i < elements->length(); ++i) { 422 for (unsigned i = 0; i < elements->length(); ++i) {
423 Element* element = elements->item(i); 423 Element* element = elements->item(i);
424 InspectorHighlight highlight(element, m_nodeHighlightConfig, false); 424 InspectorHighlight highlight(element, m_nodeHighlightConfig, false);
425 RefPtr<JSONObject> highlightJSON = highlight.asJSONObject(); 425 RefPtr<JSONObject> highlightJSON = highlight.asJSONObject();
426 evaluateInOverlay("drawHighlight", highlightJSON.release()); 426 evaluateInOverlay("drawHighlight", highlightJSON.release());
427 } 427 }
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 771
772 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node) 772 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node)
773 { 773 {
774 if (node && node->isElementNode() && m_inspectMode == InspectorDOMAgent::Sho wLayoutEditor && !m_layoutEditor) { 774 if (node && node->isElementNode() && m_inspectMode == InspectorDOMAgent::Sho wLayoutEditor && !m_layoutEditor) {
775 m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_dom Agent, &overlayMainFrame()->script()); 775 m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_dom Agent, &overlayMainFrame()->script());
776 toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverr idden(true); 776 toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverr idden(true);
777 } 777 }
778 } 778 }
779 779
780 } // namespace blink 780 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698