pkg/analysis_server/tool/spec/codegen_java.dart - Issue 1431683002: Refactor analysis server code generation to re-use logic from analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/tool/spec/codegen_java.dart

Issue 1431683002: Refactor analysis server code generation to re-use logic from analyzer. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/tool/spec/codegen_inttest_methods.dart ('k') | pkg/analysis_server/tool/spec/codegen_java_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/tool/spec/codegen_java.dart

diff --git a/pkg/analysis_server/tool/spec/codegen_java.dart b/pkg/analysis_server/tool/spec/codegen_java.dart

index a06af6b74982a10ad5316b0de91ea20cf7d4ece6..3b7a4d2769c3c25837501b2b0ffc493660647657 100644

--- a/pkg/analysis_server/tool/spec/codegen_java.dart

+++ b/pkg/analysis_server/tool/spec/codegen_java.dart

@@ -7,10 +7,10 @@

library CodegenJava;

+import 'package:analyzer/src/codegen/tools.dart';

import 'package:html/dom.dart' as dom;

import 'api.dart';

-import 'codegen_tools.dart';

import 'from_html.dart';

import 'to_html.dart';

@@ -20,8 +20,8 @@ import 'to_html.dart';

GeneratedFile javaGeneratedFile(

String path, CodegenJavaVisitor createVisitor(Api api)) {

- return new GeneratedFile(path, () {

- CodegenJavaVisitor visitor = createVisitor(readApi());

+ return new GeneratedFile(path, (String pkgPath) {

+ CodegenJavaVisitor visitor = createVisitor(readApi(pkgPath));

return visitor.collectCode(visitor.visitApi);

});

}