Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: pkg/analysis_server/tool/spec/check_all_test.dart

Issue 1431683002: Refactor analysis server code generation to re-use logic from analyzer. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/pubspec.yaml ('k') | pkg/analysis_server/tool/spec/codegen_analysis_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/check_all_test.dart
diff --git a/pkg/analysis_server/tool/spec/check_all_test.dart b/pkg/analysis_server/tool/spec/check_all_test.dart
index f068f42908489560fa191fb4d0a5578d1d5f14f5..d43b320a9ac46f9f34d1d272374649f5c596628a 100644
--- a/pkg/analysis_server/tool/spec/check_all_test.dart
+++ b/pkg/analysis_server/tool/spec/check_all_test.dart
@@ -6,9 +6,9 @@ library check.all;
import 'dart:io';
+import 'package:analyzer/src/codegen/tools.dart';
import 'package:path/path.dart';
-import 'codegen_tools.dart';
import 'generate_all.dart';
/**
@@ -17,26 +17,6 @@ import 'generate_all.dart';
*/
main() {
String script = Platform.script.toFilePath(windows: Platform.isWindows);
- Directory.current = new Directory(dirname(script));
- bool generateAllNeeded = false;
- for (GeneratedContent generatedContent in allTargets) {
- if (!generatedContent.check()) {
- print(
- '${generatedContent.outputFile.absolute} does not have expected contents.');
- generateAllNeeded = true;
- }
- }
- if (generateAllNeeded) {
- print('Please regenerate using:');
- String executable = Platform.executable;
- String packageRoot = '';
- if (Platform.packageRoot.isNotEmpty) {
- packageRoot = ' --package-root=${Platform.packageRoot}';
- }
- String generateScript = join(dirname(script), 'generate_all.dart');
- print(' $executable$packageRoot $generateScript');
- exit(1);
- } else {
- print('All generated files up to date.');
- }
+ String pkgPath = normalize(join(dirname(script), '..', '..'));
+ GeneratedContent.checkAll(pkgPath, 'tool/spec/generate_all.dart', allTargets);
}
« no previous file with comments | « pkg/analysis_server/pubspec.yaml ('k') | pkg/analysis_server/tool/spec/codegen_analysis_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698