Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431683002: Refactor analysis server code generation to re-use logic from analyzer. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor analysis server code generation to re-use logic from analyzer. The code generation infrastructure logic is now shared. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ac5578d03ded9cccdb53f0661f877914a6e9a310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -1181 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/check_all_test.dart View 2 chunks +3 lines, -23 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 1 chunk +3 lines, -9 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 2 chunks +4 lines, -11 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 2 chunks +6 lines, -11 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 3 chunks +42 lines, -47 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 chunk +5 lines, -11 lines 0 comments Download
D pkg/analysis_server/tool/spec/codegen_tools.dart View 1 chunk +0 lines, -557 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_all.dart View 3 chunks +10 lines, -12 lines 0 comments Download
D pkg/analysis_server/tool/spec/html_tools.dart View 1 chunk +0 lines, -137 lines 0 comments Download
M pkg/analysis_server/tool/spec/implied_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
D pkg/analysis_server/tool/spec/text_formatter.dart View 1 chunk +0 lines, -246 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 5 chunks +102 lines, -108 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-11-02 21:50:20 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-03 00:04:45 UTC) #3
Paul Berry
5 years, 1 month ago (2015-11-03 00:18:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ac5578d03ded9cccdb53f0661f877914a6e9a310 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698