Issue 1431673003: Compute covering offsets/lengths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1431673003: Compute covering offsets/lengths. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Compute covering offsets/lengths. Drop support for binary expressions fragments. Reduce number of reported problems, provide best guess results instead. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/128250a9eaf21b9de43363f336a6efb1aaf3615b

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+261 lines, -249 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/strings.dart	View	2 chunks	+22 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	7 chunks	+7 lines, -112 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_local.dart	View	9 chunks	+72 lines, -51 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/refactoring.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_local_test.dart	View	24 chunks	+148 lines, -86 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 1 month ago (2015-11-03 02:22:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
128250a9eaf21b9de43363f336a6efb1aaf3615b (presubmit successful).