Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431663002: Update android SDK to API version 23. (Closed)

Created:
5 years, 1 month ago by qsr
Modified:
5 years, 1 month ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update android SDK to API version 23. Also handles new android permission API by requesting needed permission upfront. R=etiennej@chromium.org BUG=Fixes https://github.com/domokit/mojo/issues/495 Committed: https://chromium.googlesource.com/external/mojo/+/7a6f76bfa8954fe979ae15033a1c88ed3e04ad84

Patch Set 1 #

Patch Set 2 : Remove M instructions. #

Total comments: 2

Patch Set 3 : Folloe review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -37 lines) Patch
M README.md View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/BUILD.gn View 3 chunks +5 lines, -1 line 0 comments Download
M shell/android/apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
A shell/android/apk/src/org/chromium/mojo/shell/BaseActivity.java View 1 chunk +72 lines, -0 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/NfcReceiverActivity.java View 2 chunks +6 lines, -6 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/SharingActivity.java View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/android/README_android_tools.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M tools/android/VERSION_LINUX_SDK View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/VERSION_MACOSX_SDK View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
qsr
5 years, 1 month ago (2015-11-02 13:27:20 UTC) #1
etiennej
lgtm https://codereview.chromium.org/1431663002/diff/20001/shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java File shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java (right): https://codereview.chromium.org/1431663002/diff/20001/shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java#newcode14 shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java:14: protected void onCreateWithPermissions() { Add doctring as in ...
5 years, 1 month ago (2015-11-02 13:40:40 UTC) #2
qsr
https://codereview.chromium.org/1431663002/diff/20001/shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java File shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java (right): https://codereview.chromium.org/1431663002/diff/20001/shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java#newcode14 shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java:14: protected void onCreateWithPermissions() { On 2015/11/02 13:40:40, etiennej wrote: ...
5 years, 1 month ago (2015-11-02 14:23:24 UTC) #3
qsr
5 years, 1 month ago (2015-11-02 14:24:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
7a6f76bfa8954fe979ae15033a1c88ed3e04ad84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698