Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: sync/internal_api/attachments/attachment_uploader_impl_unittest.cc

Issue 1431653003: Migrating tests to use EmbeddedTestServer (misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/drive/files_list_request_runner_unittest.cc ('k') | sync/internal_api/http_bridge_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc b/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
index ce545bec6222019278a0e225f869fc03665f569f..bd0ae513ab2f9e36e8ea0d16931eb6e6d686968a 100644
--- a/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
+++ b/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
@@ -224,7 +224,7 @@ class AttachmentUploaderImplTest : public testing::Test,
scoped_ptr<RequestHandler> request_handler_;
scoped_ptr<AttachmentUploader> uploader_;
AttachmentUploader::UploadCallback upload_callback_;
- net::test_server::EmbeddedTestServer server_;
+ net::EmbeddedTestServer server_;
// A closure that signals an upload has finished.
base::Closure signal_upload_done_;
std::vector<HttpRequest> http_requests_received_;
@@ -282,7 +282,7 @@ void AttachmentUploaderImplTest::SetUp() {
url_request_context_getter_ =
new net::TestURLRequestContextGetter(message_loop_.task_runner());
- ASSERT_TRUE(server_.InitializeAndWaitUntilReady());
+ ASSERT_TRUE(server_.Start());
server_.RegisterRequestHandler(
base::Bind(&RequestHandler::HandleRequest,
base::Unretained(request_handler_.get())));
« no previous file with comments | « google_apis/drive/files_list_request_runner_unittest.cc ('k') | sync/internal_api/http_bridge_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698