extensions/browser/guest_view/web_view/web_view_apitest.cc - Issue 1431653003: Migrating tests to use EmbeddedTestServer (misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 1431653003: Migrating tests to use EmbeddedTestServer (misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_apitest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc

index e4ca00b2f42cd660ff4ca8219504bda831047b4f..378cafc27ff20c7588c48cdf6e3572649962dbf5 100644

--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc

@@ -196,7 +196,7 @@ void WebViewAPITest::SetUpOnMainThread() {

void WebViewAPITest::StartTestServer() {

// For serving guest pages.

- if (!embedded_test_server()->InitializeAndWaitUntilReady()) {

+ if (!embedded_test_server()->Start()) {

LOG(ERROR) << "Failed to start test server.";

return;

}