extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc - Issue 1431653003: Migrating tests to use EmbeddedTestServer (misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 1431653003: Migrating tests to use EmbeddedTestServer (misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/template_url_fetcher_unittest.cc ('k') | extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

index 7b443c63091ae651aae221418094290234ddba29..5c2fa34cd985eac05d21aa429d2b224ebcb235f8 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

@@ -137,10 +137,10 @@ TEST(WebRequestConditionAttributeTest, ContentType) {

std::string error;

scoped_refptr<const WebRequestConditionAttribute> result;

- net::test_server::EmbeddedTestServer test_server;

+ net::EmbeddedTestServer test_server;

test_server.ServeFilesFromDirectory(TestDataPath(

"chrome/test/data/extensions/api_test/webrequest/declarative"));

- ASSERT_TRUE(test_server.InitializeAndWaitUntilReady());

+ ASSERT_TRUE(test_server.Start());

net::TestURLRequestContext context;

net::TestDelegate delegate;

@@ -525,10 +525,10 @@ TEST(WebRequestConditionAttributeTest, ResponseHeaders) {

// Necessary for TestURLRequest.

base::MessageLoopForIO message_loop;