Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3108)

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

Issue 1431653003: Migrating tests to use EmbeddedTestServer (misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
index 14e92096103590b7fa99bb0100735b633f2b7c8b..fa77c74580a4892e6afe68652a9c587ca3bb3de6 100644
--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
@@ -197,11 +197,11 @@ class PhishingClassifierDelegateTest : public InProcessBrowserTest {
bool StartTestServer() {
CHECK(!embedded_test_server_);
- embedded_test_server_.reset(new net::test_server::EmbeddedTestServer());
+ embedded_test_server_.reset(new net::EmbeddedTestServer());
embedded_test_server_->RegisterRequestHandler(
base::Bind(&PhishingClassifierDelegateTest::HandleRequest,
base::Unretained(this)));
- return embedded_test_server_->InitializeAndWaitUntilReady();
+ return embedded_test_server_->Start();
mmenke 2015/11/05 18:21:03 Per comment in other file, can also switch this to
svaldez 2015/11/05 18:34:51 Done.
}
scoped_ptr<net::test_server::HttpResponse> HandleRequest(
@@ -256,7 +256,7 @@ class PhishingClassifierDelegateTest : public InProcessBrowserTest {
scoped_refptr<InterceptingMessageFilter> intercepting_filter_;
GURL response_url_;
std::string response_content_;
- scoped_ptr<net::test_server::EmbeddedTestServer> embedded_test_server_;
+ scoped_ptr<net::EmbeddedTestServer> embedded_test_server_;
scoped_ptr<ClientPhishingRequest> verdict_;
StrictMock<MockPhishingClassifier>* classifier_; // Owned by |delegate_|.
int32_t render_view_routing_id_;

Powered by Google App Engine
This is Rietveld 408576698