Migrating tests to use EmbeddedTestServer (misc)

chrome/test/nacl/nacl_browsertest_util.cc

Index: chrome/test/nacl/nacl_browsertest_util.cc
diff --git a/chrome/test/nacl/nacl_browsertest_util.cc b/chrome/test/nacl/nacl_browsertest_util.cc
index d24588f8f347f97158f54e01a6cd67f4f6f725fa..a5d1ee39cee88401b2865cd3f14227c5ecf17e81 100644
--- a/chrome/test/nacl/nacl_browsertest_util.cc
+++ b/chrome/test/nacl/nacl_browsertest_util.cc
@@ -19,6 +19,7 @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/webplugininfo.h"
 #include "net/base/net_util.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"

[mmenke, 2015/11/05 17:38:13]

This is included in the header, so not needed (Could forward declare in the
header, alternatively, but then I suspect you'd break other files that aren't
IWYU-clean).

[svaldez, 2015/11/05 18:15:55]

Done.

 
 typedef content::TestMessageHandler::MessageResponse MessageResponse;
 
@@ -210,7 +211,7 @@ bool NaClBrowserTestBase::IsAPnaclTest() {
 
 GURL NaClBrowserTestBase::TestURL(
     const base::FilePath::StringType& url_fragment) {
-  base::FilePath expanded_url = base::FilePath(FILE_PATH_LITERAL("files"));
+  base::FilePath expanded_url = base::FilePath(FILE_PATH_LITERAL("/"));
   expanded_url = expanded_url.Append(url_fragment);
   return test_server_->GetURL(expanded_url.MaybeAsASCII());
 }
@@ -259,10 +260,8 @@ bool NaClBrowserTestBase::StartTestServer() {
   base::FilePath document_root;
   if (!GetDocumentRoot(&document_root))
     return false;
-  test_server_.reset(new net::SpawnedTestServer(
-                         net::SpawnedTestServer::TYPE_HTTP,
-                         net::SpawnedTestServer::kLocalhost,
-                         document_root));
+  test_server_.reset(new net::EmbeddedTestServer);
+  test_server_->ServeFilesFromSourceDirectory(document_root);
   return test_server_->Start();
 }