Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 143163005: Revert of Revert "Serialization of SkPictureImageFilter" (Closed)

Created:
6 years, 10 months ago by rmistry
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Revert "Serialization of SkPictureImageFilter" (https://codereview.chromium.org/153583007/) Reason for revert: New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22 Original issue's description: > Revert "Serialization of SkPictureImageFilter" > > This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. > > Revert "Sanitizing source files in Housekeeper-Nightly" > > This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. > > TBR=robertphillips@google.com,sugoi@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13356 TBR=robertphillips@google.com,sugoi@google.com,fmalita@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -69 lines) Patch
M gm/colorfilters.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImage.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPicture.h View 4 chunks +20 lines, -1 line 0 comments Download
M include/effects/SkColorMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +7 lines, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +34 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 5 chunks +92 lines, -20 lines 0 comments Download
M src/core/SkPicturePlayback.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 3 chunks +40 lines, -0 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +16 lines, -2 lines 0 comments Download
M src/image/SkImage.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/MatrixClipCollapseTest.cpp View 20 chunks +36 lines, -36 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmistry
Created Revert of Revert "Serialization of SkPictureImageFilter"
6 years, 10 months ago (2014-02-07 12:19:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/143163005/1
6 years, 10 months ago (2014-02-07 12:19:54 UTC) #2
commit-bot: I haz the power
Change committed as 13357
6 years, 10 months ago (2014-02-07 12:20:09 UTC) #3
tomhudson
This CL is the only thing in the blamelist for a 4x regression of tabl_frantzen:Perf-Win8-ShuttleA-GTX660-x86-Release:simple_viewport_1000x1000 ...
6 years, 10 months ago (2014-02-11 12:14:40 UTC) #4
sugoi
6 years, 10 months ago (2014-02-11 12:26:06 UTC) #5
Message was sent while issue was closed.
On 2014/02/11 12:14:40, tomhudson wrote:
> This CL is the only thing in the blamelist for a 4x regression of
> tabl_frantzen:Perf-Win8-ShuttleA-GTX660-x86-Release:simple_viewport_1000x1000
> (at
>
http://0.skia-gwt-dash.chrome-skia.ic.borg.google.com:26275/#b-52%7Ec-718%7Er-15).
> 
> Some further poking around suggests it's a 4x regression on ALL architectures.
> Filed https://code.google.com/p/skia/issues/detail?id=2159.

Most of this cl's code is unused. The important part is that PICTURE_VERSION was
changed and that all SKPs were re-recorded. The new SKPs must be more complex /
contain more features than the previous ones (like having AA enabled, higher
resolution, etc). A first idea could be to compare version 19 SKPs and version
20 SKPs.

Powered by Google App Engine
This is Rietveld 408576698