Issue 14316003: Fixed slide show in Files.app's gallery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14316003: Fixed slide show in Files.app's gallery. (Closed)

Created:
7 years, 8 months ago by mtomasz

Modified:
7 years, 8 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed slide show in Files.app's gallery. Because of typo, gallery wasn't showing up. This patch fixes the typo and also converts every instance of toggleFullscreen to toggleFullScreen for consistency. TEST=Enter Files.app, go to gallery, fire the slide show. BUG=232087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194764

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/js/media/video_player.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/photo/slide_mode.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14316003/1

7 years, 8 months ago (2013-04-18 01:31:21 UTC) #4

mtomasz

7 years, 8 months ago (2013-04-18 04:47:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r194764 (presubmit successful).

Expand Messages | Collapse Messages