Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431593007: Merge to XFA: Fix all relative includes to public. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix all relative includes to public. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1415803007 . (cherry picked from commit 5899671184d01b74989d181363066379ef3e4051) Committed: https://pdfium.googlesource.com/pdfium/+/b4e7f304af0ad92d20f952e6634000d177974f47

Patch Set 1 #

Patch Set 2 : self review #

Total comments: 4

Patch Set 3 : XFA #

Patch Set 4 : IWYU, AKA fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -76 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_searchex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfview_c_api_test.c View 1 chunk +15 lines, -15 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +4 lines, -4 lines 0 comments Download
M testing/embedder_test.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M testing/test_support.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
I recommend starting with fpdfsdk/src/fpdfsave.cpp, fpdfsdk/src/fpdftext.cpp, and fpdfsdk/src/fpdfview.cpp in patch set 2. Then look at ...
5 years, 1 month ago (2015-11-06 23:00:44 UTC) #1
Tom Sepez
lgtm https://codereview.chromium.org/1431593007/diff/20001/fpdfsdk/src/fpdfsave.cpp File fpdfsdk/src/fpdfsave.cpp (right): https://codereview.chromium.org/1431593007/diff/20001/fpdfsdk/src/fpdfsave.cpp#newcode7 fpdfsdk/src/fpdfsave.cpp:7: #include "public/fpdf_save.h" nit: fpdf_save isn't fpdsave. https://codereview.chromium.org/1431593007/diff/20001/fpdfsdk/src/fpdftext.cpp File ...
5 years, 1 month ago (2015-11-06 23:15:11 UTC) #2
Lei Zhang
https://codereview.chromium.org/1431593007/diff/20001/fpdfsdk/src/fpdfsave.cpp File fpdfsdk/src/fpdfsave.cpp (right): https://codereview.chromium.org/1431593007/diff/20001/fpdfsdk/src/fpdfsave.cpp#newcode7 fpdfsdk/src/fpdfsave.cpp:7: #include "public/fpdf_save.h" On 2015/11/06 23:15:10, Tom Sepez wrote: > ...
5 years, 1 month ago (2015-11-06 23:51:38 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-06 23:52:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b4e7f304af0ad92d20f952e6634000d177974f47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698