Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/html_viewer/layout_test_content_handler_impl.cc

Issue 1431573002: Fix hangs in Mandoline page cycler on Linux with --enable-multiprocess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/layout_test_content_handler_impl.h ('k') | components/pdf_viewer/pdf_viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/layout_test_content_handler_impl.cc
diff --git a/components/html_viewer/layout_test_content_handler_impl.cc b/components/html_viewer/layout_test_content_handler_impl.cc
index 25c887d62d30142d86d421f64df847004e4911dc..b076472139ea1c5e39147567d41388606cb0ba7a 100644
--- a/components/html_viewer/layout_test_content_handler_impl.cc
+++ b/components/html_viewer/layout_test_content_handler_impl.cc
@@ -52,14 +52,16 @@ LayoutTestContentHandlerImpl::LayoutTestContentHandlerImpl(
: ContentHandlerImpl(global_state, app, request.Pass()),
test_interfaces_(test_interfaces),
test_delegate_(test_delegate),
- web_widget_proxy_(nullptr) {}
+ web_widget_proxy_(nullptr),
+ app_refcount_(app->app_lifetime_helper()->CreateAppRefCount()) {}
LayoutTestContentHandlerImpl::~LayoutTestContentHandlerImpl() {
}
void LayoutTestContentHandlerImpl::StartApplication(
mojo::InterfaceRequest<mojo::Application> request,
- mojo::URLResponsePtr response) {
+ mojo::URLResponsePtr response,
+ const mojo::Callback<void()>& destruct_callback) {
test_interfaces_->SetTestIsRunning(true);
test_interfaces_->ConfigureForTestWithURL(GURL(), false);
@@ -67,7 +69,8 @@ void LayoutTestContentHandlerImpl::StartApplication(
HTMLDocumentApplicationDelegate* delegate =
new HTMLDocumentApplicationDelegate(
request.Pass(), response.Pass(), global_state(),
- app()->app_lifetime_helper()->CreateAppRefCount());
+ app()->app_lifetime_helper()->CreateAppRefCount(),
+ destruct_callback);
delegate->set_html_factory(this);
}
« no previous file with comments | « components/html_viewer/layout_test_content_handler_impl.h ('k') | components/pdf_viewer/pdf_viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698