Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: components/html_viewer/content_handler_impl.cc

Issue 1431573002: Fix hangs in Mandoline page cycler on Linux with --enable-multiprocess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/html_viewer/content_handler_impl.cc
diff --git a/components/html_viewer/content_handler_impl.cc b/components/html_viewer/content_handler_impl.cc
index f858aa6de0efda3e4cc530920f2511498e737e33..2fdcdbf3bec6f09ac136895d36c165fb092faa9c 100644
--- a/components/html_viewer/content_handler_impl.cc
+++ b/components/html_viewer/content_handler_impl.cc
@@ -12,7 +12,10 @@ ContentHandlerImpl::ContentHandlerImpl(
GlobalState* global_state,
mojo::ApplicationImpl* app,
mojo::InterfaceRequest<mojo::ContentHandler> request)
- : global_state_(global_state), app_(app), binding_(this, request.Pass()) {
+ : global_state_(global_state),
+ app_(app),
+ binding_(this, request.Pass()),
+ app_refcount_(app_->app_lifetime_helper()->CreateAppRefCount()) {
}
ContentHandlerImpl::~ContentHandlerImpl() {
@@ -20,11 +23,12 @@ ContentHandlerImpl::~ContentHandlerImpl() {
void ContentHandlerImpl::StartApplication(
mojo::InterfaceRequest<mojo::Application> request,
- mojo::URLResponsePtr response) {
+ mojo::URLResponsePtr response,
+ const mojo::Callback<void()>& destruct_callback) {
// HTMLDocumentApplicationDelegate deletes itself.
new HTMLDocumentApplicationDelegate(
request.Pass(), response.Pass(), global_state_,
- app_->app_lifetime_helper()->CreateAppRefCount());
+ app_->app_lifetime_helper()->CreateAppRefCount(), destruct_callback);
}
} // namespace html_viewer
« no previous file with comments | « components/html_viewer/content_handler_impl.h ('k') | components/html_viewer/html_document_application_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698