Handle prohibited technologies in device policy ONC

chromeos/network/prohibited_technologies_handler_unittest.cc

Index: chromeos/network/prohibited_technologies_handler_unittest.cc
diff --git a/chromeos/network/prohibited_technologies_handler_unittest.cc b/chromeos/network/prohibited_technologies_handler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a7e507acdbbad7ad88467deacfa4dd6744bcf049
--- /dev/null
+++ b/chromeos/network/prohibited_technologies_handler_unittest.cc
@@ -0,0 +1,191 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/network/prohibited_technologies_handler.h"
+
+#include <string>
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/shill_manager_client.h"
+#include "chromeos/dbus/shill_profile_client.h"
+#include "chromeos/network/managed_network_configuration_handler_impl.h"
+#include "chromeos/network/network_configuration_handler.h"
+#include "chromeos/network/network_profile_handler.h"
+#include "chromeos/network/network_state_handler.h"
+#include "chromeos/network/onc/onc_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+namespace {
+

[stevenjb, 2015/11/11 18:07:31]

no blank line

[fqj, 2015/11/12 10:23:01]

Done.

+const char* kUserHash = "user_hash";
+}
+
+class ProhibitedTechnologiesHandlerTest : public testing::Test {
+ public:
+  ProhibitedTechnologiesHandlerTest() {}
+
+  void SetUp() override {
+    DBusThreadManager::Initialize();
+    LoginState::Initialize();
+    DBusThreadManager* dbus_manager = DBusThreadManager::Get();
+    test_manager_client_ =
+        dbus_manager->GetShillManagerClient()->GetTestInterface();
+
+    test_manager_client_->AddTechnology(shill::kTypeWifi, true /* enabled */);
+    test_manager_client_->AddTechnology(shill::kTypeCellular,
+                                        true /* enabled */);
+    dbus_manager->GetShillProfileClient()->GetTestInterface()->AddProfile(
+        "shared_profile_path", std::string() /* shared profile */);
+    dbus_manager->GetShillProfileClient()->GetTestInterface()->AddProfile(
+        "user_profile_path", kUserHash);
+
+    base::RunLoop().RunUntilIdle();
+    network_state_handler_.reset(NetworkStateHandler::InitializeForTest());
+    network_config_handler_.reset(
+        NetworkConfigurationHandler::InitializeForTest(
+            network_state_handler_.get(), NULL /* network_device_handler */));
+
+    network_profile_handler_.reset(new NetworkProfileHandler());
+    network_profile_handler_->Init();
+
+    managed_config_handler_.reset(new ManagedNetworkConfigurationHandlerImpl());
+    prohibited_technologies_handler_.reset(new ProhibitedTechnologiesHandler());
+
+    managed_config_handler_->Init(
+        network_state_handler_.get(), network_profile_handler_.get(),
+        network_config_handler_.get(), nullptr /* network_device_handler */,
+        prohibited_technologies_handler_.get());
+
+    prohibited_technologies_handler_->Init(managed_config_handler_.get(),
+                                           network_state_handler_.get());
+
+    base::RunLoop().RunUntilIdle();
+
+    PreparePolicies();
+  }
+
+  void PreparePolicies() {
+    scoped_ptr<base::ListValue> val(new base::ListValue());
+    val->AppendString("WiFi");
+    global_config_disable_wifi.Set("DisableNetworkTypes", val.Pass());
+    val.reset(new base::ListValue());
+    val->AppendString("WiFi");
+    val->AppendString("Cellular");
+    global_config_disable_wifi_and_cell.Set("DisableNetworkTypes", val.Pass());
+  }
+
+  void TearDown() override {
+    prohibited_technologies_handler_.reset();
+    managed_config_handler_.reset();
+    network_profile_handler_.reset();
+    network_config_handler_.reset();
+    network_state_handler_.reset();
+    LoginState::Shutdown();
+    DBusThreadManager::Shutdown();
+  }
+
+ protected:
+  void LoginToRegularUser() {
+    LoginState::Get()->SetLoggedInState(LoginState::LOGGED_IN_ACTIVE,
+                                        LoginState::LOGGED_IN_USER_REGULAR);
+    base::RunLoop().RunUntilIdle();
+  }
+
+  void SetupPolicy(const base::DictionaryValue& global_config,
+                   bool user_policy) {
+    if (user_policy) {
+      managed_config_handler_->SetPolicy(::onc::ONC_SOURCE_USER_POLICY,
+                                         kUserHash, base::ListValue(),
+                                         global_config);
+    } else {
+      managed_config_handler_->SetPolicy(::onc::ONC_SOURCE_DEVICE_POLICY,
+                                         std::string(),  // no username hash
+                                         base::ListValue(), global_config);
+    }
+    base::RunLoop().RunUntilIdle();
+  }
+
+  scoped_ptr<ProhibitedTechnologiesHandler> prohibited_technologies_handler_;
+  scoped_ptr<NetworkStateHandler> network_state_handler_;
+  scoped_ptr<NetworkConfigurationHandler> network_config_handler_;
+  scoped_ptr<ManagedNetworkConfigurationHandlerImpl> managed_config_handler_;
+  scoped_ptr<NetworkProfileHandler> network_profile_handler_;
+  ShillManagerClient::TestInterface* test_manager_client_;
+  base::MessageLoopForUI message_loop_;
+  base::DictionaryValue global_config_disable_wifi;
+  base::DictionaryValue global_config_disable_wifi_and_cell;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ProhibitedTechnologiesHandlerTest);
+};
+
+TEST_F(ProhibitedTechnologiesHandlerTest,
+       ProhibitedTechnologiesAllowedLoginScreen) {
+  EXPECT_TRUE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_TRUE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+  SetupPolicy(global_config_disable_wifi_and_cell, false);
+  EXPECT_TRUE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_TRUE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+};
+
+TEST_F(ProhibitedTechnologiesHandlerTest,
+       ProhibitedTechnologiesNotAllowedUserSession) {
+  EXPECT_TRUE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_TRUE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+  SetupPolicy(global_config_disable_wifi_and_cell, false);
+
+  LoginToRegularUser();
+  EXPECT_TRUE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_TRUE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+
+  SetupPolicy(base::DictionaryValue(), true);  // wait for user policy
+
+  // Should be disabled after logged in
+  EXPECT_FALSE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_FALSE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+
+  // Can not enable it back
+  network_state_handler_->SetTechnologyEnabled(
+      NetworkTypePattern::WiFi(), true, network_handler::ErrorCallback());
+  network_state_handler_->SetTechnologyEnabled(
+      NetworkTypePattern::Cellular(), true, network_handler::ErrorCallback());
+  message_loop_.RunUntilIdle();
+  EXPECT_FALSE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_FALSE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+
+  // Can enable Cellular back after modifying policy
+  SetupPolicy(global_config_disable_wifi, false);
+  network_state_handler_->SetTechnologyEnabled(
+      NetworkTypePattern::WiFi(), true, network_handler::ErrorCallback());
+  network_state_handler_->SetTechnologyEnabled(
+      NetworkTypePattern::Cellular(), true, network_handler::ErrorCallback());
+  message_loop_.RunUntilIdle();
+  EXPECT_FALSE(
+      network_state_handler_->IsTechnologyEnabled(NetworkTypePattern::WiFi()));
+  EXPECT_TRUE(network_state_handler_->IsTechnologyEnabled(
+      NetworkTypePattern::Cellular()));
+};
+
+}  // namespace chromeos