Handle prohibited technologies in device policy ONC

chromeos/network/network_state_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state_handler.h"
 
 #include "base/bind.h"
 #include "base/format_macros.h"
 #include "base/guid.h"
 #include "base/json/json_string_value_serializer.h"
@@ skipping 126 matching lines @@
       continue;
     NET_LOG_USER("SetTechnologyEnabled",
                  base::StringPrintf("%s:%d", technology->c_str(), enabled));
     shill_property_handler_->SetTechnologyEnabled(*technology, enabled,
                                                   error_callback);
   }
   // Signal Device/Technology state changed.
   NotifyDeviceListChanged();
 }
 
+void NetworkStateHandler::SetProhibitedTechnologies(
+    const std::vector<std::string>& prohibited_technologies,
+    const network_handler::ErrorCallback& error_callback) {
+  std::vector<std::string> technology_list;
+  for (const std::string& prohibited_technology : prohibited_technologies)
+    technology_list.push_back(prohibited_technology);

[stevenjb, 2015/11/11 18:07:31]

Why are we copying a vector<string> to a vector<string>?

[fqj, 2015/11/12 10:23:01]

Done.

+  shill_property_handler_->SetProhibitedTechnologies(technology_list,
+                                                     error_callback);
+  // Signal Device/Technology state changed.
+  NotifyDeviceListChanged();
+}
+
 const DeviceState* NetworkStateHandler::GetDeviceState(
     const std::string& device_path) const {
   const DeviceState* device = GetModifiableDeviceState(device_path);
   if (device && !device->update_received())
     return nullptr;
   return device;
 }
 
 const DeviceState* NetworkStateHandler::GetDeviceStateByType(
     const NetworkTypePattern& type) const {
@@ skipping 826 matching lines @@
   if (type.MatchesType(shill::kTypeBluetooth))
     technologies.push_back(new std::string(shill::kTypeBluetooth));
   if (type.MatchesType(shill::kTypeVPN))
     technologies.push_back(new std::string(shill::kTypeVPN));
 
   CHECK_GT(technologies.size(), 0ul);
   return technologies.Pass();
 }
 
 }  // namespace chromeos