Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1431543002: [turbofan] Optimize inlining and direct function calls. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize inlining and direct function calls. This adds optimized lowering for JSConvertReceiver (in the general case) and JSToObject in typed lowering. It also uses JSConvertReceiver for direct calls in typed lowering. R=mstarzinger@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/47c0cb1d149182adcf1ec5792a1bd55c7d177e0b Cr-Commit-Position: refs/heads/master@{#31676}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -17 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +156 lines, -17 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-30 09:16:57 UTC) #1
Benedikt Meurer
Hey Michi, Here's the fastification for calls we talked about. Please take a look. Thanks, ...
5 years, 1 month ago (2015-10-30 09:17:35 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1431543002/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1431543002/diff/1/src/compiler/js-typed-lowering.cc#newcode847 src/compiler/js-typed-lowering.cc:847: Reduction JSTypedLowering::ReduceJSToObject(Node* node) { nit: Can we haz ...
5 years, 1 month ago (2015-10-30 09:55:01 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1431543002/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1431543002/diff/1/src/compiler/js-typed-lowering.cc#newcode847 src/compiler/js-typed-lowering.cc:847: Reduction JSTypedLowering::ReduceJSToObject(Node* node) { Of course :-)
5 years, 1 month ago (2015-10-30 10:00:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431543002/20001
5 years, 1 month ago (2015-10-30 10:01:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 10:24:39 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 10:25:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47c0cb1d149182adcf1ec5792a1bd55c7d177e0b
Cr-Commit-Position: refs/heads/master@{#31676}

Powered by Google App Engine
This is Rietveld 408576698