Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 143153005: Replace mic key with search in a11y keyboard. (Closed)

Created:
6 years, 10 months ago by rsadam
Modified:
6 years, 10 months ago
Reviewers:
bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace mic key with search in a11y keyboard. BUG=339196 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247983

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/keyboard/resources/layouts/system-qwerty.html View 2 chunks +4 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
rsadam
6 years, 10 months ago (2014-01-29 20:24:39 UTC) #1
bshe
https://codereview.chromium.org/143153005/diff/1/ui/keyboard/resources/layouts/system-qwerty.html File ui/keyboard/resources/layouts/system-qwerty.html (right): https://codereview.chromium.org/143153005/diff/1/ui/keyboard/resources/layouts/system-qwerty.html#newcode29 ui/keyboard/resources/layouts/system-qwerty.html:29: <kb-key class="search dark" char="Search" image='search' weight="150"> do you need ...
6 years, 10 months ago (2014-01-29 20:28:00 UTC) #2
rsadam
On 2014/01/29 20:28:00, bshe wrote: > https://codereview.chromium.org/143153005/diff/1/ui/keyboard/resources/layouts/system-qwerty.html > File ui/keyboard/resources/layouts/system-qwerty.html (right): > > https://codereview.chromium.org/143153005/diff/1/ui/keyboard/resources/layouts/system-qwerty.html#newcode29 > ...
6 years, 10 months ago (2014-01-29 20:31:34 UTC) #3
bshe
On 2014/01/29 20:31:34, rsadam wrote: > On 2014/01/29 20:28:00, bshe wrote: > > > https://codereview.chromium.org/143153005/diff/1/ui/keyboard/resources/layouts/system-qwerty.html ...
6 years, 10 months ago (2014-01-29 20:36:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/143153005/1
6 years, 10 months ago (2014-01-29 20:40:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253699
6 years, 10 months ago (2014-01-29 23:36:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/143153005/1
6 years, 10 months ago (2014-01-30 15:35:12 UTC) #7
commit-bot: I haz the power
Change committed as 247983
6 years, 10 months ago (2014-01-30 17:46:22 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 17:46:24 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698