Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 143153004: [Reland] Fix crash when accidentally touching the screen during a multi window resize (Closed)

Created:
6 years, 11 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, dcheng
Visibility:
Public.

Description

Fix crash when accidentally touching the screen during a multi window resize BUG=330672 TEST=*DetachToBrowserTabDragControllerTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247544

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -43 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 5 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Scott, can you please take another look? The previous CL (Patch set# 1) had a ...
6 years, 11 months ago (2014-01-25 23:54:15 UTC) #1
sky
Ok, LGTM
6 years, 10 months ago (2014-01-27 14:56:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/143153004/120001
6 years, 10 months ago (2014-01-28 18:22:31 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 00:41:49 UTC) #4
Message was sent while issue was closed.
Change committed as 247544

Powered by Google App Engine
This is Rietveld 408576698