Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1431513012: Fix for 23806 - don't optimize out Array allocation that may throw (Closed)

Created:
5 years, 1 month ago by sra1
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for 23806 - don't optimize out Array allocation that may throw BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9efe59cc020eedfbf4d3f773a1f6c5c1d9ed7111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
5 years, 1 month ago (2015-11-06 00:29:29 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 1 month ago (2015-11-06 00:33:30 UTC) #3
Siggi Cherem (dart-lang)
lgtm
5 years, 1 month ago (2015-11-06 00:33:31 UTC) #4
sra1
5 years, 1 month ago (2015-11-06 02:11:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9efe59cc020eedfbf4d3f773a1f6c5c1d9ed7111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698