Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431513010: Revert "Normalize type masks to use the least upper instantiated subclass/type." (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Normalize type masks to use the least upper instantiated subclass/type." This reverts commit d3c68df8532fee63cd846fda7130d28c99c591df. BUG= Committed: https://github.com/dart-lang/sdk/commit/c1b102a94dbc6a7a0ffe022d4bef26f9390a90f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -591 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 3 chunks +40 lines, -70 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 2 chunks +5 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 4 chunks +19 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 6 chunks +6 lines, -88 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 5 chunks +27 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 7 chunks +26 lines, -79 lines 0 comments Download
M tests/compiler/dart2js/members_test.dart View 10 chunks +1 line, -19 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 5 chunks +4 lines, -23 lines 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 3 chunks +147 lines, -211 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +13 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR poi :(
5 years, 1 month ago (2015-11-05 10:14:24 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as c1b102a94dbc6a7a0ffe022d4bef26f9390a90f2 (presubmit successful).
5 years, 1 month ago (2015-11-05 10:15:00 UTC) #3
sigurdm
5 years, 1 month ago (2015-11-05 10:17:04 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698