src/js/macros.py - Issue 1431503002: Avoid creating indexed elements at index maxUint32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/macros.py

Issue 1431503002: Avoid creating indexed elements at index maxUint32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use Jakob's suggestion for a more robust check Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/macros.py

diff --git a/src/js/macros.py b/src/js/macros.py

index 856158aa898e6b509eb7fd7b0afc2036b497c149..f9bb12b705023c348d43a165c46b416aa2ec99d6 100644

--- a/src/js/macros.py

+++ b/src/js/macros.py

@@ -73,6 +73,9 @@ define kSafeArgumentsLength = 0x800000;

# 2^53 - 1

define kMaxSafeInteger = 9007199254740991;

+# 2^32 - 1

+define kMaxUint32 = 4294967295;

# Strict mode flags for passing to %SetProperty

define kSloppyMode = 0;

define kStrictMode = 1;

« no previous file with comments | « no previous file | src/js/runtime.js » ('j') | no next file with comments »