Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/js/runtime.js

Issue 1431503002: Avoid creating indexed elements at index maxUint32 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/macros.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/runtime.js
diff --git a/src/js/runtime.js b/src/js/runtime.js
index 54fe40d45f89b9135a4a6551086f6ecbf49dc721..5d02bd18ff66fe1fe9d45d99ecc694e020788312 100644
--- a/src/js/runtime.js
+++ b/src/js/runtime.js
@@ -210,7 +210,7 @@ function ConcatIterableToArray(target, iterable) {
// argument might not be less than 2**32-1. ES2015 ToLength semantics mean that
// this is a concern at basically all callsites.
function AddIndexedProperty(obj, index, value) {
- if (index === TO_UINT32(index)) {
+ if (index < kMaxUint32) {
Jakob Kummerow 2015/10/30 09:38:05 How do you guarantee that index >= 0?
%AddElement(obj, index, value);
} else {
%AddNamedProperty(obj, TO_STRING(index), value, NONE);
« no previous file with comments | « src/js/macros.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698