Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 # pylint: disable=F0401 | |
| 6 import recipe_util | |
|
M-A Ruel
2013/04/24 13:09:14
stdlib import first
then local imports
janx
2013/04/26 10:05:09
Done.
| |
| 7 import sys | |
| 8 | |
|
M-A Ruel
2013/04/24 13:09:14
2 lines
janx
2013/04/26 10:05:09
Done.
| |
| 9 # pylint: disable=W0232 | |
|
M-A Ruel
2013/04/24 13:09:14
Can you add a single line comment with what this w
agable
2013/04/24 18:04:09
It's "class has no __init__ method", and it's my b
janx
2013/04/26 10:05:09
Done.
| |
| 10 class Android(recipe_util.Recipe): | |
| 11 """Basic Recipe alias for Android -> Chromium.""" | |
| 12 | |
| 13 @staticmethod | |
| 14 def fetch_spec(props): | |
| 15 return { | |
| 16 'alias': { | |
| 17 'recipe': 'chromium', | |
| 18 'props': ['--target_os=android'] | |
|
M-A Ruel
2013/04/24 13:09:14
Append comma
janx
2013/04/26 10:05:09
Done.
| |
| 19 } | |
|
M-A Ruel
2013/04/24 13:09:14
Here too
janx
2013/04/26 10:05:09
Done.
| |
| 20 } | |
| 21 | |
| 22 | |
| 23 def main(argv=None): | |
| 24 Android().handle_args(argv) | |
|
M-A Ruel
2013/04/24 13:09:14
return ?
Aaron, does handle_args returns an int?
agable
2013/04/24 18:04:09
Yes, right this should be "return Android..."
janx
2013/04/26 10:05:09
Done.
| |
| 25 | |
| 26 | |
| 27 if __name__ == '__main__': | |
| 28 sys.exit(main(sys.argv)) | |
| OLD | NEW |