Add Kerberos support to webview

android_webview/browser/net/aw_url_request_context_getter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_BROWSER_NET_AW_URL_REQUEST_CONTEXT_GETTER_H_
 #define ANDROID_WEBVIEW_BROWSER_NET_AW_URL_REQUEST_CONTEXT_GETTER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/content_browser_client.h"
+#include "net/http/http_auth_handler_negotiate.h"
 #include "net/http/http_network_session.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_job_factory.h"
 
+class PrefService;
+
 namespace net {
 class CookieStore;
+class HostResolver;
 class HttpTransactionFactory;
 class HttpUserAgentSettings;
 class NetLog;
 class ProxyConfigService;
 class URLRequestContext;
 class URLRequestJobFactory;
+class URLSecurityManager;
 }
 
 namespace android_webview {
 
 class AwNetworkDelegate;
 
 class AwURLRequestContextGetter : public net::URLRequestContextGetter {
  public:
-  AwURLRequestContextGetter(
-      const base::FilePath& cache_path,
-      net::CookieStore* cookie_store,
-      scoped_ptr<net::ProxyConfigService> config_service);
+  AwURLRequestContextGetter(const base::FilePath& cache_path,
+                            net::CookieStore* cookie_store,
+                            scoped_ptr<net::ProxyConfigService> config_service,
+                            PrefService* pref_service);
 
   // net::URLRequestContextGetter implementation.
   net::URLRequestContext* GetURLRequestContext() override;
   scoped_refptr<base::SingleThreadTaskRunner> GetNetworkTaskRunner()
       const override;
 
   // NetLog is thread-safe, so clients can call this method from arbitrary
   // threads (UI and IO).
   net::NetLog* GetNetLog();
 
@@ skipping 10 matching lines @@
   // |job_factory_|.  This ordering is enforced by having
   // AwBrowserContext::CreateRequestContext() call this method.
   // This method is necessary because the passed in objects are created
   // on the UI thread while |job_factory_| must be created on the IO thread.
   void SetHandlersAndInterceptors(
       content::ProtocolHandlerMap* protocol_handlers,
       content::URLRequestInterceptorScopedVector request_interceptors);
 
   void InitializeURLRequestContext();
 
+  // This is called to create a HttpAuthHandlerFactory that will handle
+  // negotiate challenges for the new URLRequestContext
+  scoped_ptr<net::HttpAuthHandlerNegotiate::Factory>

[sgurun-gerrit only, 2015/11/13 08:43:51]

yeah, how will this work, it is only NET_EXPORT_PRIVATE.

[dgn, 2015/11/13 12:37:07]

Didn't notice that when I wrote the patch, and I got told, NET_EXPORT_PRIVATE
and NET_EXPORT are the same for now so I didn't notice. AFAIK, the only other
option we have now is to get the default AuthHandlerFactory created by the
builder, then throw it away and replace it with a new one that supports
negotiate. I'll go with that and once
https://codereview.chromium.org/1414313002/ lands, it should be possible to
initialize negotiate on android with the URLRequestContext Builder

[sgurun-gerrit only, 2015/11/18 02:23:28]

the other cl already accumulated a lot of lgtm's so seems close to land?

[dgn, 2015/11/25 00:27:15]

What I mentioned above doesn't seem to work anymore, as the factory seems to be
copied to a http session object during the initialization via the builder. I'll
see if exporting the classes to configure the builder is doable instead.

[dgn, 2015/11/25 19:01:08]

Fixed. I'm not creating a factory registry configured only for negotiate and
adding it as extra factory to the builder.

+  CreateNegotiateAuthHandlerFactory(net::HostResolver* resolver);
+
   const base::FilePath cache_path_;
 
   scoped_ptr<net::NetLog> net_log_;
   scoped_ptr<net::ProxyConfigService> proxy_config_service_;
   scoped_ptr<net::HttpNetworkSession> http_network_session_;
   scoped_ptr<net::HttpTransactionFactory> main_http_factory_;
   scoped_refptr<net::CookieStore> cookie_store_;
   scoped_ptr<net::URLRequestJobFactory> job_factory_;
   scoped_ptr<net::HttpUserAgentSettings> http_user_agent_settings_;
   scoped_ptr<net::URLRequestContext> url_request_context_;
 
+  // URLSecurityManager associated with the negotiate auth handler. It is
+  // configured to follow the auth_server_whitelist_
+  scoped_ptr<net::URLSecurityManager> url_security_manager_;
+
+  // Store HTTP Auth-related policies in this thread.
+  std::string auth_android_negotiate_account_type_;
+  std::string auth_server_whitelist_;
+
   // ProtocolHandlers and interceptors are stored here between
   // SetHandlersAndInterceptors() and the first GetURLRequestContext() call.
   content::ProtocolHandlerMap protocol_handlers_;
   content::URLRequestInterceptorScopedVector request_interceptors_;
 
   DISALLOW_COPY_AND_ASSIGN(AwURLRequestContextGetter);
 };
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_BROWSER_NET_AW_URL_REQUEST_CONTEXT_GETTER_H_