Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: src/heap/heap.cc

Issue 1431443002: [heap] Add histogram timers for incremental marking start and finalization event. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/counters.h ('k') | src/heap/incremental-marking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 scavenge_job_->ScheduleIdleTaskIfNeeded(this, bytes_allocated); 785 scavenge_job_->ScheduleIdleTaskIfNeeded(this, bytes_allocated);
786 } 786 }
787 787
788 788
789 void Heap::FinalizeIncrementalMarking(const char* gc_reason) { 789 void Heap::FinalizeIncrementalMarking(const char* gc_reason) {
790 if (FLAG_trace_incremental_marking) { 790 if (FLAG_trace_incremental_marking) {
791 PrintF("[IncrementalMarking] (%s).\n", gc_reason); 791 PrintF("[IncrementalMarking] (%s).\n", gc_reason);
792 } 792 }
793 793
794 GCTracer::Scope gc_scope(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE); 794 GCTracer::Scope gc_scope(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE);
795 HistogramTimerScope incremental_marking_scope(
796 isolate()->counters()->gc_incremental_marking_finalize());
795 797
796 { 798 {
797 GCCallbacksScope scope(this); 799 GCCallbacksScope scope(this);
798 if (scope.CheckReenter()) { 800 if (scope.CheckReenter()) {
799 AllowHeapAllocation allow_allocation; 801 AllowHeapAllocation allow_allocation;
800 GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL); 802 GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL);
801 VMState<EXTERNAL> state(isolate_); 803 VMState<EXTERNAL> state(isolate_);
802 HandleScope handle_scope(isolate_); 804 HandleScope handle_scope(isolate_);
803 CallGCPrologueCallbacks(kGCTypeIncrementalMarking, kNoGCCallbackFlags); 805 CallGCPrologueCallbacks(kGCTypeIncrementalMarking, kNoGCCallbackFlags);
804 } 806 }
(...skipping 5378 matching lines...) Expand 10 before | Expand all | Expand 10 after
6183 } 6185 }
6184 6186
6185 6187
6186 // static 6188 // static
6187 int Heap::GetStaticVisitorIdForMap(Map* map) { 6189 int Heap::GetStaticVisitorIdForMap(Map* map) {
6188 return StaticVisitorBase::GetVisitorId(map); 6190 return StaticVisitorBase::GetVisitorId(map);
6189 } 6191 }
6190 6192
6191 } // namespace internal 6193 } // namespace internal
6192 } // namespace v8 6194 } // namespace v8
OLDNEW
« no previous file with comments | « src/counters.h ('k') | src/heap/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698