Check for main frame existence in VisualViewport::setScaleAndLocation.

Check for main frame existence in VisualViewport::setScaleAndLocation.

I missed this null check in setScaleAndLocation. There's some edge cases, likely
during loading, where we might get here without a frame. Also, until we figure
out what to do with VisualViewport for OOPIF we could also have a null
mainFrame.

BUG=543945
Committed: https://crrev.com/d27923720c70c15eec621e564a66d28eab16e807
Cr-Commit-Position: refs/heads/master@{#357146}

[bokan, 2015-10-30 16:32:01]

Description was changed from

==========
Add null check for VisualViewport::mainFrame existence.

I missed this null check in setScaleAndLocation. There's some edge cases, likely
during loading, where we might get here without a frame. Also, until we figure
out what to do with VisualViewport for OOPIF we could also have a null
mainFrame.

BUG=543945
==========

to

==========
Add null check for VisualViewport::mainFrame existence.

I missed this null check in setScaleAndLocation. There's some edge cases, likely
during loading, where we might get here without a frame. Also, until we figure
out what to do with VisualViewport for OOPIF we could also have a null
mainFrame.

BUG=543945
==========

[bokan, 2015-10-30 16:32:01]

bokan@chromium.org changed reviewers:
+ majidvp@chromium.org

[bokan, 2015-10-30 16:32:28]

ptal (no test since there's no repro and it's a trivial check)

[majidvp, 2015-10-30 17:03:05]

On 2015/10/30 16:32:28, bokan wrote:
> ptal (no test since there's no repro and it's a trivial check)

lgtm.

minor nit: I think it is better to rewrite the first commit line to mention
VisualViewport::setScaleAndLocation e.g.,
"Add main frame existence check in VisualViewport::setScaleAndLocation"

[bokan, 2015-10-30 17:23:29]

Description was changed from

==========
Add null check for VisualViewport::mainFrame existence.

I missed this null check in setScaleAndLocation. There's some edge cases, likely
during loading, where we might get here without a frame. Also, until we figure
out what to do with VisualViewport for OOPIF we could also have a null
mainFrame.

BUG=543945
==========

to

==========
Check for main frame existence in VisualViewport::setScaleAndLocation.

I missed this null check in setScaleAndLocation. There's some edge cases, likely
during loading, where we might get here without a frame. Also, until we figure
out what to do with VisualViewport for OOPIF we could also have a null
mainFrame.

BUG=543945
==========

[bokan, 2015-10-30 17:23:38]

On 2015/10/30 17:03:05, majidvp wrote:
> On 2015/10/30 16:32:28, bokan wrote:
> > ptal (no test since there's no repro and it's a trivial check)
> 
> lgtm.
> 
> minor nit: I think it is better to rewrite the first commit line to mention
> VisualViewport::setScaleAndLocation e.g.,
> "Add main frame existence check in VisualViewport::setScaleAndLocation"

Done.

[bokan, 2015-10-30 17:23:44]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-10-30 17:23:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431433005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431433005/1

[commit-bot: I haz the power, 2015-10-30 18:41:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-30 18:42:13]

Patchset 1 (id:??) landed as
https://crrev.com/d27923720c70c15eec621e564a66d28eab16e807
Cr-Commit-Position: refs/heads/master@{#357146}