Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1431433004: Revert of Remove RegExp.multiline accessors. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove RegExp.multiline accessors. (patchset #3 id:40001 of https://codereview.chromium.org/1410993008/ ) Reason for revert: [Sheriff] Causes layout test failures. Original issue's description: > Remove RegExp.multiline accessors. > > This is non-standard and not even documented on MDN. > > On Firefox, setting RegExp.multiline to true adds the multiline flag to all > newly created RegExp objects (both from constructor and from literal). > > In V8 this has no effect. > > Source archaelogy shows that this is from the initial commit. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/e8f752ce0c2a488e88cd87fe75f3907b4303d0a0 > Cr-Commit-Position: refs/heads/master@{#31673} TBR=bmeurer@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8a2618a986de60fa1ac137ec1810a4b3592a366e Cr-Commit-Position: refs/heads/master@{#31679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M src/js/regexp.js View 1 chunk +19 lines, -0 lines 0 comments Download
M test/mjsunit/regexp-static.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Remove RegExp.multiline accessors.
5 years, 1 month ago (2015-10-30 10:46:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431433004/1
5 years, 1 month ago (2015-10-30 10:46:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 10:46:57 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 10:47:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a2618a986de60fa1ac137ec1810a4b3592a366e
Cr-Commit-Position: refs/heads/master@{#31679}

Powered by Google App Engine
This is Rietveld 408576698