Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431423002: Add ref-qualified member functions as undiscussed in the C++11 guide. (Closed)

Created:
5 years, 1 month ago by danakj
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ref-qualified member functions as undiscussed in the C++11 guide. R=thakis@chromium.org BUG=554287 Committed: https://crrev.com/9d92a1db85705dadb31f9558c49b583cfef1a181 Cr-Commit-Position: refs/heads/master@{#358983}

Patch Set 1 #

Patch Set 2 : refqual: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M styleguide/c++/c++11.html View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431423002/20001
5 years, 1 month ago (2015-11-11 00:04:35 UTC) #2
danakj
5 years, 1 month ago (2015-11-11 00:08:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 00:13:51 UTC) #5
Nico
lgtm, thanks
5 years, 1 month ago (2015-11-11 00:37:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431423002/20001
5 years, 1 month ago (2015-11-11 00:39:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-11 00:47:26 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 00:48:21 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9d92a1db85705dadb31f9558c49b583cfef1a181
Cr-Commit-Position: refs/heads/master@{#358983}

Powered by Google App Engine
This is Rietveld 408576698