Initial support for f-bound quantification patterns

Initial support for f-bound quantification patterns

This doesn't fix all issues (see remaining broken test), but it unblocks angular.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/ef3b9cf4973c255ad860a1370780c1224b8cef36

[vsm, 2015-11-10 23:20:24]

Description was changed from

==========
Initial support for f-bound quantification patterns

This doesn't fix all issues (see remaining broken test), but it unblocks
angular.
==========

to

==========
Initial support for f-bound quantification patterns

This doesn't fix all issues (see remaining broken test), but it unblocks
angular.
==========

[vsm, 2015-11-10 23:20:25]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[vsm, 2015-11-10 23:20:30]

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:569: final _hasDeferredSupertype = new
Set<ClassElement>();
Not sure I need a Set here, but with the load-on-demand logic, I wasn't sure
what kind of nesting patterns I'd see.

[Jennifer Messerly, 2015-11-10 23:32:09]

LGTM!

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:569: final _hasDeferredSupertype = new
Set<ClassElement>();
On 2015/11/10 23:20:29, vsm wrote:
> Not sure I need a Set here, but with the load-on-demand logic, I wasn't sure
> what kind of nesting patterns I'd see.

yeah seems fine. small nit: you could use HashSet, that way you won't pay the
linked list cost, since we don't traverse it order shouldn't matter

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:577: if ((current == typeElement) ||
_deferIfNeeded(typeArg, current)) {
parens not needed around ==

[vsm, 2015-11-10 23:41:50]

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:569: final _hasDeferredSupertype = new
Set<ClassElement>();
On 2015/11/10 23:32:09, John Messerly wrote:
> On 2015/11/10 23:20:29, vsm wrote:
> > Not sure I need a Set here, but with the load-on-demand logic, I wasn't sure
> > what kind of nesting patterns I'd see.
> 
> yeah seems fine. small nit: you could use HashSet, that way you won't pay the
> linked list cost, since we don't traverse it order shouldn't matter

Done.

https://codereview.chromium.org/1431403002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:577: if ((current == typeElement) ||
_deferIfNeeded(typeArg, current)) {
On 2015/11/10 23:32:09, John Messerly wrote:
> parens not needed around ==

Done.

[vsm, 2015-11-10 23:42:16]

Committed patchset #2 (id:20001) manually as
ef3b9cf4973c255ad860a1370780c1224b8cef36 (presubmit successful).