fix dom.py

tools/dom/dom.py

 #!/usr/bin/python
 
 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # A script which makes it easy to execute common DOM-related tasks
 
 import os
 import subprocess
 import sys
+from sys import argv

[Jennifer Messerly, 2013/04/27 01:06:58]

making sure argv is defined for all the commands
alternatively -- I could pass it in to each command function

 
 sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
 import utils
 
 dart_out_dir = utils.GetBuildRoot(utils.GuessOS(), 'release', 'ia32')
 if utils.IsWindows():
   dart_bin = os.path.join(dart_out_dir, 'dart.exe')
 else:
   dart_bin = os.path.join(dart_out_dir, 'dart')
 
@@ skipping 68 matching lines @@
     '-o%s' % out_file
   ]
   if checked:
     args.append('--checked')
 
   call(args)
   return out_file
 
 def gen():
   os.chdir(os.path.join('tools', 'dom', 'scripts'))
-  return call(os.path.join(os.getcwd(), 'go.sh'))
+  return call([os.path.join(os.getcwd(), 'dartdomgenerator.py'),

[Jennifer Messerly, 2013/04/27 01:06:58]

the "reset" in go.sh fails for me because it doesn't have a valid terminal
stdout/stderr. Since go.sh is a tiny wrapper around dartdomgenerator I figure we
can just call this directly.

+      '--rebuild', '--parallel', '--systems=htmldart2js,htmldartium'])
 
 def http_server():
   print('Browse tests at '
       '\033[94mhttp://localhost:5400/root_build/generated_tests/\033[0m')
   return call([
     utils.DartBinary(),
     os.path.join('tools', 'testing', 'dart', 'http_server.dart'),
     '--port=5400',
     '--crossOriginPort=5401',
     '--network=0.0.0.0',
@@ skipping 72 matching lines @@
   'test_chrome': [test_chrome, 'Run tests in checked mode in Chrome.\n'
       '\t\tOptionally provide name of test to run.'],
   'test_drt': [test_drt, 'Run tests in checked mode in DumpRenderTree.\n'
       '\t\tOptionally provide name of test to run.'],
   'test_ff': [test_ff, 'Run tests in checked mode in Firefox.\n'
       '\t\tOptionally provide name of test to run.'],
   'http_server': [http_server, 'Starts the testing server for manually '
       'running browser tests.'],
 }
 
-def main(argv):
+def main():
   success = True
   argv.pop(0)
 
   if not argv:
     help()
     success = False
 
   while (argv):
     init_dir()
     command = argv.pop(0)
 
     if not command in commands:
       help();
       success = False
       break
     returncode = commands[command][0]()
     success = success and not bool(returncode)
 
   sys.exit(not success)
 
 if __name__ == '__main__':
-  main(sys.argv)
+  main()