Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 14314008: Add FontMgr to DirectWrite. (Closed)

Created:
7 years, 8 months ago by bungeman-skia
Modified:
7 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add FontMgr to DirectWrite.

Patch Set 1 #

Patch Set 2 : Fix some line lengths. #

Patch Set 3 : Use modified SkAutoSTMalloc instead of SkSTDArray. #

Patch Set 4 : Add matcher, fix GrGLCaps. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -62 lines) Patch
M include/core/SkTemplates.h View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M include/utils/win/SkTScopedComPtr.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 1 chunk +8 lines, -6 lines 3 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 2 3 7 chunks +255 lines, -52 lines 0 comments Download
M tests/FontMgrTest.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bungeman-skia
Adds a FontMgr implementation for DirectWrite. The SkTDArray.h changes are under separate review at https://codereview.chromium.org/14502003/ ...
7 years, 8 months ago (2013-04-26 19:48:28 UTC) #1
reed1
lets try to land the SkTDArray change (plus some unittests) separately.
7 years, 8 months ago (2013-04-26 20:37:41 UTC) #2
bungeman-skia
Patch Set 3 just moves to using a modified SkAutoSTMalloc instead of a new SkSTDArray. ...
7 years, 7 months ago (2013-04-29 21:44:34 UTC) #3
bungeman-skia
https://codereview.chromium.org/14314008/diff/12001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/14314008/diff/12001/src/gpu/gl/GrGLCaps.cpp#newcode222 src/gpu/gl/GrGLCaps.cpp:222: if (numFormats) { The 'debug' gl context sets numFormats ...
7 years, 7 months ago (2013-04-29 22:59:06 UTC) #4
bungeman-skia
Adding bsalomon for the change to GrGLCaps.cpp. I've reviewed existing uses of SkAutoSTMalloc, and aside ...
7 years, 7 months ago (2013-04-30 17:02:36 UTC) #5
reed1
lgtm
7 years, 7 months ago (2013-04-30 20:00:35 UTC) #6
bsalomon
On 2013/04/30 20:00:35, reed1 wrote: > lgtm lgtm
7 years, 7 months ago (2013-04-30 20:03:02 UTC) #7
bungeman-skia
7 years, 7 months ago (2013-05-01 14:22:25 UTC) #8
Message was sent while issue was closed.
Committed revision 8934.

Powered by Google App Engine
This is Rietveld 408576698